Skip to content

perf(android): [SDK Overhead Reduction 3] Reuse SentryExecutorService for DeviceInfoUtil pre-caching #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adinauer wants to merge 1 commit into
base: perf/sdk-overhead-reduction
Choose a base branch
from
+3 −5
Draft

perf(android): [SDK Overhead Reduction 3] Reuse SentryExecutorService for DeviceInfoUtil pre-caching #5502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import java.util.concurrent.RejectedExecutionException;
import org.jetbrains.annotations.NotNull;
Expand Down Expand Up @@ -56,16 +54,16 @@ public DefaultAndroidEventProcessor(
// noinspection Convert2MethodRef
// some device info performs disk I/O, but it's result is cached, let's pre-cache it
@Nullable Future<DeviceInfoUtil> deviceInfoUtil;
final @NotNull ExecutorService executorService = Executors.newSingleThreadExecutor();
try {
deviceInfoUtil =
executorService.submit(() -> DeviceInfoUtil.getInstance(this.context, options));
options
.getExecutorService()
.submit(() -> DeviceInfoUtil.getInstance(this.context, options));
} catch (RejectedExecutionException e) {
deviceInfoUtil = null;
options.getLogger().log(SentryLevel.WARNING, "Device info caching task rejected.", e);
}
this.deviceInfoUtil = deviceInfoUtil;
executorService.shutdown();
}

@Override
Expand Down
Loading