Skip to content

fix(android): identify and correctly structure Java/Kotlin frames… #5116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
supervacuus wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix(android): identify and correctly structure Java/Kotlin frames… #5116

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6930694
fix(android): identify and correctly structure Java/Kotlin frames in …
supervacuus Feb 25, 2026
4d4b081
update changelog
supervacuus Feb 25, 2026
1ee2738
Merge branch 'main' into fix/android/id_java_kotlin_frames_tombstone
supervacuus Feb 25, 2026
35e1010
support PrettyMethod with_signature formatted java frames
supervacuus Feb 25, 2026
2af3888
Merge branch 'main' into fix/android/id_java_kotlin_frames_tombstone
supervacuus Mar 13, 2026
0635d8a
If there is no module name, module should be null
supervacuus Mar 13, 2026
10dd21c
test: assert null java module for bare tombstone methods
cursoragent Mar 13, 2026
9025dfe
test(android): add proguard tombstone test cases (#5117)
supervacuus Mar 13, 2026
f7473a5
clean up TombstoneParser.normalizeFunctionName()
supervacuus Mar 13, 2026
1fdf9f5
Merge branch 'main' into fix/android/id_java_kotlin_frames_tombstone
supervacuus Mar 26, 2026
dee5f92
refactor tombstone java frame name normalization
cursoragent Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor tombstone java frame name normalization 
Applied via @cursor push command
  • Loading branch information
@cursoragent
cursoragent committed Mar 26, 2026
commit dee5f92a2b1926aa1e2ea018d26b8f3bf025823a
21 changes: 10 additions & 11 deletions ...android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,9 @@ private SentryStackTrace createStackTrace(@NonNull final TombstoneThread thread)
final SentryStackFrame stackFrame = new SentryStackFrame();
if (isJavaFrame(frame)) {
stackFrame.setPlatform("java");
final String module = extractJavaModuleName(frame.functionName);
stackFrame.setFunction(extractJavaFunctionName(frame.functionName));
final String normalizedFunctionName = normalizeFunctionName(frame.functionName);
final String module = extractJavaModuleName(normalizedFunctionName);
stackFrame.setFunction(extractJavaFunctionName(normalizedFunctionName));
stackFrame.setModule(module);

// For Java frames, check in-app against the module (package name), which is what
Expand Down Expand Up @@ -217,21 +218,19 @@ private static String normalizeFunctionName(String fqFunctionName) {
return normalized;
}

private static @Nullable String extractJavaModuleName(String fqFunctionName) {
final String normalized = normalizeFunctionName(fqFunctionName);
if (normalized.contains(".")) {
return normalized.substring(0, normalized.lastIndexOf("."));
private static @Nullable String extractJavaModuleName(String normalizedFunctionName) {
if (normalizedFunctionName.contains(".")) {
return normalizedFunctionName.substring(0, normalizedFunctionName.lastIndexOf("."));
} else {
return null;
}
}
Comment thread
cursor[bot] marked this conversation as resolved.

private static @Nullable String extractJavaFunctionName(String fqFunctionName) {
final String normalized = normalizeFunctionName(fqFunctionName);
if (normalized.contains(".")) {
return normalized.substring(normalized.lastIndexOf(".") + 1);
private static @Nullable String extractJavaFunctionName(String normalizedFunctionName) {
if (normalizedFunctionName.contains(".")) {
return normalizedFunctionName.substring(normalizedFunctionName.lastIndexOf(".") + 1);
} else {
return normalized;
return normalizedFunctionName;
}
}
Comment thread
cursor[bot] marked this conversation as resolved.

Expand Down
Loading