Skip to content

Support for androidx.sqlite's SQLiteDriver #5002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angusholder wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support for androidx.sqlite's SQLiteDriver #5002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43ab407
Add SQLiteDriver implementation
angusholder Jan 5, 2026
8a224b6
Add tests
angusholder Jan 6, 2026
7a5dade
Add doc comments
angusholder Jan 6, 2026
149441f
Switch to using a factory method like SentrySupportSQLiteOpenHelper
angusholder Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Switch to using a factory method like SentrySupportSQLiteOpenHelper
  • Loading branch information
@angusholder
angusholder committed Jan 6, 2026
commit 149441f882e9b59fc9814ab078d9d36c5fbae62c
25 changes: 17 additions & 8 deletions sentry-android-sqlite/src/main/java/io/sentry/android/sqlite/SentrySQLiteDriver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,21 @@ import io.sentry.ScopesAdapter
*
* Usage - wrap this around your current [SQLiteDriver]:
* ```
* val driver = SentrySQLiteDriver(AndroidSQLiteDriver())
* val driver = SentrySQLiteDriver.create(AndroidSQLiteDriver())
* ```
*
* If you use Room you can wrap the default [AndroidSQLiteDriver]:
* ```
* val database = Room.databaseBuilder(context, MyDatabase::class.java, "dbName")
* .setDriver(SentrySQLiteDriver(AndroidSQLiteDriver()))
* .setDriver(SentrySQLiteDriver.create(AndroidSQLiteDriver()))
* ...
* .build()
* ```
*/
public class SentrySQLiteDriver internal constructor(
private val scopes: IScopes,
private val delegate: SQLiteDriver,
private val scopes: IScopes = ScopesAdapter.getInstance(),
) : SQLiteDriver {
/**
* @param delegate The [SQLiteDriver] instance to delegate calls to.
*/
public constructor(delegate: SQLiteDriver) : this(ScopesAdapter.getInstance(), delegate)

override fun open(fileName: String): SQLiteConnection {
val sqliteSpanManager = SQLiteSpanManager(
scopes,
Expand All @@ -44,6 +39,20 @@ public class SentrySQLiteDriver internal constructor(
val connection = delegate.open(fileName)
return SentrySQLiteConnection(connection, sqliteSpanManager)
}

public companion object {
/**
* @param delegate The [SQLiteDriver] instance to delegate calls to.
*/
@JvmStatic
public fun create(delegate: SQLiteDriver): SQLiteDriver {
if (delegate is SentrySQLiteDriver) {
return delegate
} else {
return SentrySQLiteDriver(delegate)
}
}
}
}

internal class SentrySQLiteConnection(
Expand Down
2 changes: 1 addition & 1 deletion sentry-android-sqlite/src/test/java/io/sentry/android/sqlite/SentrySQLiteDriverTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class SentrySQLiteDriverTest {
sentryTracer = SentryTracer(TransactionContext("name", "op"), scopes)
whenever(scopes.span).thenReturn(sentryTracer)

return SentrySQLiteDriver(scopes, mockDriver)
return SentrySQLiteDriver(mockDriver, scopes)
}
}

Expand Down