Repository navigation
feat(seer): Add transformation plumbing to query embeds - #129790
nsdeschenes wants to merge 3 commits into
Conversation
Refs EXP-1425
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-baeeczlbf.sentry.dev |
📊 Type Coverage Diff✅ no issues found |
Restore the existing query blocks and chart renderer. Forward pipelines through existing requests and handoffs, using events-timeseries only for transformed spans. Refs EXP-1425
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dbbbd37. Configure here.
| yAxes: resolveMetricYAxes(data), | ||
| transformations, | ||
| }), | ||
| aggregateSortBys: sort ? [sort] : undefined, |
There was a problem hiding this comment.
Metrics sort handoff is invalid
High Severity
Removing resolveMetricSort leaves Explore and the events table with an unqualified sort string. aggregateSortBys now stores raw sort instead of a {field, kind} object, so decodeMetricsQueryParams drops it and samples lose sortBys entirely. The table orderby also no longer qualifies or aliases the field, so a Seer sort such as -p95(value) does not match the selected metric columns and the preview request can fail. The no-sort fallback uses fields[0], which is the group-by column when one is present.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit dbbbd37. Configure here.
| sort: groupBy?.length ? eventView.sorts[0] : undefined, | ||
| }, | ||
| 'seer-spans-query-embed' | ||
| ); |
There was a problem hiding this comment.
Missing unsupported transformation alert
Medium Severity
The replacement chart paths send transformation pipelines to events-timeseries without checking explore-interpolation-and-smoothing. The previous shared renderer skipped the request and showed a warning when the org lacked that capability. Orgs that receive a transformed embed but cannot execute pipelines now get a generic load error, or untransformed data, instead of the documented unsupported-capability alert.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit dbbbd37. Configure here.
Why
Query embeds need to forward requested transformations to execution and Explore. Keep this change scoped to transformation plumbing in the existing embed components.
What changed
Scope
This frontend PR is stacked on #129789. It keeps the existing query blocks and chart renderer. General changes to gap, unit, and per-bucket provenance rendering are outside this PR.
Blast radius
Deploy the backend contract first, then this frontend. Enable
seer-explorer-transformed-query-embedsonly after frontend deployment.Verification
Refs EXP-1425