ERR trap misreports wizard failure as install failure

Medium Severity

The ERR trap (line 75) is still active when sentry init </dev/tty runs. Since set -e is in effect, any failure of the wizard — missing TTY, user cancellation, network error — triggers die "Unexpected failure at line $LINENO", printing a scary red error and sending a false-positive telemetry event to Sentry. The install already succeeded at that point, so the optional wizard step's failure gets misreported as a catastrophic install failure.

 

^{Reviewed by Cursor Bugbot for commit 8b97caa. Configure here.}

Empty SENTRY_INSTALL_DIR causes check of root /sentry

Low Severity

When SENTRY_INSTALL_DIR is unset, ${SENTRY_INSTALL_DIR:-} expands to an empty string, so the first loop iteration checks -x "/sentry" (a file at the filesystem root). This is unlikely to match in practice, but it's a logic error that could theoretically resolve to the wrong binary. The empty-string directory entry needs to be skipped or filtered out.

 

^{Reviewed by Cursor Bugbot for commit 85afd5f. Configure here.}

Bug: The script's ERR trap is not cleared before calling sentry init. A non-zero exit from the wizard, like a user cancellation, will incorrectly trigger a fatal script error.
_{Severity: MEDIUM}

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: install#L302

Potential issue: The install script sets an `ERR` trap at the beginning to catch
unexpected failures. This trap is not cleared before executing `sentry init`. If the
`sentry init` command exits with a non-zero status code, which can happen if the user
cancels the wizard with Ctrl+C or if an error occurs, the script's `ERR` trap will be
triggered. This results in the script terminating and sending a misleading telemetry
event for an "Unexpected failure", rather than allowing the wizard to exit gracefully on
its own.