refactor(1/12): remove deprecated logging tools#319
Open
cameroncooke wants to merge 1 commit intomainfrom
Open
refactor(1/12): remove deprecated logging tools#319cameroncooke wants to merge 1 commit intomainfrom
cameroncooke wants to merge 1 commit intomainfrom
Conversation
585faf0 to
9a660e0
Compare
Comment on lines
23
to
27
| - get_app_bundle_id | ||
| - screenshot | ||
| - snapshot_ui | ||
| - stop_sim_log_cap | ||
| - start_sim_log_cap | ||
| - get_coverage_report | ||
| - get_file_coverage |
There was a problem hiding this comment.
Bug: The test it('includes logging tools', ...) will fail because it asserts the presence of start_sim_log_cap and stop_sim_log_cap, which have been removed from the simulator workflow.
Severity: HIGH
Suggested Fix
Update the test it('includes logging tools', ...) in src/smoke-tests/__tests__/e2e-mcp-discovery.test.ts to remove the assertions for start_sim_log_cap and stop_sim_log_cap, aligning the test with the updated workflow.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: manifests/workflows/simulator.yaml#L23-L27
Potential issue: The changes in `manifests/workflows/simulator.yaml` remove the
`start_sim_log_cap` and `stop_sim_log_cap` steps from the `simulator` workflow. However,
a corresponding change was not made in the test file
`src/smoke-tests/__tests__/e2e-mcp-discovery.test.ts`. This test file contains a test
case, `it('includes logging tools', ...)`, which explicitly asserts the presence of
these removed logging tools. Consequently, this test will fail during execution,
blocking the CI/CD pipeline.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 1 of 12 in a stacked PR series that decouples the rendering pipeline from MCP transport. This PR can be reviewed and merged independently.
Removes all deprecated logging tools that were superseded by the unified log capture approach. These tools (
start_sim_log_cap,stop_sim_log_cap,start_device_log_cap,stop_device_log_cap,launch_app_logs_sim) used a start/stop session model that was fragile and leaked resources. The replacement (already shipped in earlier releases) integrates log capture directly into build-and-run workflows, making these standalone logging tools dead code.What changes
src/mcp/tools/logging/)launch_app_logs_simtool (simulator variant that combined launch + log capture)loggingworkflow manifestdeviceandsimulatorworkflow manifestsWhy
These tools have been deprecated since the log capture was integrated into build-run workflows. Removing them before the rendering pipeline refactor avoids migrating dead code to the new handler contract, keeping subsequent PRs in this stack cleaner.
Stack navigation
Test plan
npx vitest runpasses (no tests reference removed tools)