Improve error handling around gh api#79
Merged
Merged
Conversation
Contributor
|
Hah! Thanks so much @mislav! I will try this out and try my best to accept the patch. 😁 ❤️ |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
emmatyping
approved these changes
Jul 6, 2022
|
Thanks again @mislav ! We appreciate the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly handle error statuses from
gh apiinstead of detecting error conditions by inspecting the first character of the output. It is not guaranteed that the first character of an erroredgh apiresponse is{, but it's definitely guaranteed that in case of HTTP 4xx–5xx responses,gh apiwill exit with a nonzero status. This approaches uses the failing status to blank out themention_slugvariable, which I find to be less hacky and more future-proof.Additionally, this avoids GitHub Actions workflow interpolation
${{...}}embedded in bash script and instead passes in variables as environment variables. The bash script may fail after expanding these placeholders if any of the expanded value contains characters like"'${}!or similar characters that have special meaning in bash. Passing in environment variables, on the other hand, is safe regardless of the value.Followup to #78. Untested. Feel free to discard ✌️ /cc @chadwhitacre
Ref. cli/cli#5209