Update Secret Scan Log Forwarding#146
Merged
Merged
Conversation
geoffg-sentry
approved these changes
Oct 30, 2024
Contributor
geoffg-sentry
left a comment
There was a problem hiding this comment.
This might end up in an awful lot of secret scan results being forwarded to Panther, since every non-failure result is also delivered. Gonna give it a try and flip if off if it ends up being too voluminous/expensive for ingest.
geoffg-sentry
added a commit
that referenced
this pull request
Oct 30, 2024
Whoops, I missed this in my review of #146. Value of status needs to be quoted. Currently the log looks like {"event":"github_secret_scanning", "status":success, "createdAt":"2024-10-30T17:20:07Z", "repo":"getsentry/gocd-jsonnet","pull_request":"https://github.com/getsentry/gocd-jsonnet/pull/83","actor":"IanWoodard"}
geoffg-sentry
added a commit
that referenced
this pull request
Oct 30, 2024
Whoops, I missed this in my review of #146. Value of status needs to be quoted. Currently the log looks like {"event":"github_secret_scanning", "status":success, "createdAt":"2024-10-30T17:20:07Z", "repo":"getsentry/gocd-jsonnet","pull_request":"https://github.com/getsentry/gocd-jsonnet/pull/83","actor":"IanWoodard"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.