Skip to content

[Issue #441] Add maintainer notes to patches #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrepapoti wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[Issue #441] Add maintainer notes to patches #586

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
caf054a
models: Add Note model
andrepapoti Mar 7, 2024
cb13754
migrations: add migration for Note
andrepapoti Mar 7, 2024
a9541d6
api: Add Note view and serializer
andrepapoti Mar 7, 2024
df9ce0e
api: Add Note to Patch Serializer
andrepapoti Mar 7, 2024
13f5fd5
urls: add endpoints for Notes
andrepapoti Mar 7, 2024
a87fd13
tests: Add tests for Note related endpoints
andrepapoti Mar 7, 2024
cafc714
admin: Add Note admin
andrepapoti Mar 7, 2024
58ea0eb
views: Add notes to patch-detail view
andrepapoti Mar 11, 2024
ded8739
release-notes: Add release notes for the patch note feature
andrepapoti Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
models: Add Note model 
Signed-off-by: andrepapoti <andrepapoti@gmail.com>
  • Loading branch information
@andrepapoti @victor-accarini
andrepapoti authored and victor-accarini committed Jan 24, 2025
commit caf054aaee4098fe8bef63675d3e4c4b4922657d
19 changes: 19 additions & 0 deletions patchwork/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ def validate_regex_compiles(regex_string):
raise ValidationError('Invalid regular expression entered!')


class TimestampMixin(models.Model):
updated_at = models.DateTimeField(auto_now=True)
created_at = models.DateTimeField(auto_now_add=True)

class Meta:
abstract = True


class Person(models.Model):
# properties

Expand Down Expand Up @@ -823,6 +831,17 @@ class Meta:
]


class Note(TimestampMixin, models.Model):
patch = models.ForeignKey(
Patch,
related_name='notes',
on_delete=models.CASCADE,
)
submitter = models.ForeignKey(User, on_delete=models.CASCADE)
content = models.TextField(null=False, blank=True)
maintainer_only = models.BooleanField(default=True)
Copy link
Copy Markdown
Member

@stephenfin stephenfin Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these not always maintainer-only? Why would we ever want to make them public?

Copy link
Copy Markdown
Author

@andrepapoti andrepapoti Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily, it may be used to transmit additional context for reviewers that may not be adequate to have in the commit message, in this context it would make sense to have public notes.

Copy link
Copy Markdown

@kuba-moo kuba-moo Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any broader discussion should happen on the mailing list, really.
If we're risking splintering the discussion I'd rather not have this feature at all :S



class Series(FilenameMixin, models.Model):
"""A collection of patches."""

Expand Down