SES: add SNS event destinations to describe_configuration_set#9023
Merged
bblommers merged 1 commit intogetmoto:masterfrom Jun 30, 2025
Merged
SES: add SNS event destinations to describe_configuration_set#9023bblommers merged 1 commit intogetmoto:masterfrom
bblommers merged 1 commit intogetmoto:masterfrom
Conversation
The template only returned the configuration set name.
1 task
dmacvicar
added a commit
to localstack/localstack
that referenced
this pull request
Jun 29, 2025
…ations Related to issue #12722 Requires getmoto/moto#9023
dmacvicar
added a commit
to localstack/localstack
that referenced
this pull request
Jun 29, 2025
…ations Related to issue #12722 Requires getmoto/moto#9023
dmacvicar
added a commit
to localstack/localstack
that referenced
this pull request
Jun 29, 2025
…ations Related to issue #12722 Requires getmoto/moto#9023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9023 +/- ##
=======================================
Coverage 92.87% 92.87%
=======================================
Files 1288 1288
Lines 113342 113346 +4
=======================================
+ Hits 105268 105272 +4
Misses 8074 8074
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bblommers
approved these changes
Jun 30, 2025
Collaborator
bblommers
left a comment
There was a problem hiding this comment.
LGTM - thanks for the fix @dmacvicar, and welcome to Moto! 🥳
2 tasks
dmacvicar
added a commit
to localstack/localstack
that referenced
this pull request
Aug 20, 2025
…ations Related to issue #12722 Requires getmoto/moto#9023
dmacvicar
added a commit
to localstack/localstack
that referenced
this pull request
Sep 25, 2025
…ations Related to issue #12722 Requires getmoto/moto#9023
dmacvicar
added a commit
to localstack/localstack
that referenced
this pull request
Sep 26, 2025
…ations Related to issue #12722 Requires getmoto/moto#9023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template only returns the configuration set name.
There are other ConfigurationSetAttributeNames that should be added in the future, like
trackingOptions | deliveryOptions | reputationOptions. Same with other types of destinations likeCloudWatchDestinationandKinesisFirehoseDestination.Related to localstack/localstack#12722