Skip to content

Fix inconsistent processing of server variables in gorillamux router #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fenollp merged 15 commits into from
Dec 16, 2022
Merged

Fix inconsistent processing of server variables in gorillamux router #705

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
09be236
Add support for formats added to recent JSON schema specification drafts
sl255051 Mar 23, 2022
543f56e
Update comment to OpenAPI v3.0.3 and add link to the specification do…
sl255051 Mar 23, 2022
e320853
Merge branch 'getkin:master' into master
slessard Mar 31, 2022
85a4de6
Fix issue https://github.com/getkin/kin-openapi/issues/367
sl255051 Mar 31, 2022
dff5cc6
Get back to 100% in sync with upstream, https://github.com/getkin/kin…
sl255051 Jun 1, 2022
a3b0058
Merge pull request #1 from getkin/master
slessard Jun 7, 2022
af773b3
Merge branch 'getkin:master' into master
slessard Oct 10, 2022
b26b31c
Merge branch 'getkin:master' into master
slessard Nov 29, 2022
745582c
Merge branch 'getkin:master' into master
slessard Dec 9, 2022
d33eab3
Extract inline function into standalone function
sl255051 Dec 14, 2022
45c1a77
Add test function to isolate differences in a doc's server value
sl255051 Dec 14, 2022
edef885
Add more unit testing in related areas for gorillamux
sl255051 Dec 14, 2022
507f6df
Merge branch 'master' into route-test
sl255051 Dec 14, 2022
1b33f15
Fix bug in unit test code
sl255051 Dec 15, 2022
61c1280
Fix for https://github.com/getkin/kin-openapi/issues/706
sl255051 Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test function to isolate differences in a doc's server value 
These two test cases should be the same, but one test fails
  • Loading branch information
@sl255051
sl255051 committed Dec 14, 2022
commit 45c1a77f18047a86ac076abd72a7c3e668f10af8
42 changes: 42 additions & 0 deletions routers/gorillamux/router_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,48 @@ import (
"github.com/getkin/kin-openapi/routers"
)

func TestRouter_Servers(t *testing.T) {
tests := []struct {
name string
server *openapi3.Server
}{
{
name: "server url is /",
server: newServerWithVariables("/", nil),
},
{
name: "server url is variable that evaluates to /",
server: newServerWithVariables("{server}", map[string]string{"server": "/"}),
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
helloGET := &openapi3.Operation{Responses: openapi3.NewResponses()}
doc := &openapi3.T{
OpenAPI: "3.0.0",
Info: &openapi3.Info{
Title: "MyAPI",
Version: "0.1",
},
Servers: []*openapi3.Server{
tt.server,
},
Paths: openapi3.Paths{
"/hello": &openapi3.PathItem{
Get: helloGET,
},
},
}

err := doc.Validate(context.Background())
require.NoError(t, err)
r, err := NewRouter(doc)
require.NoError(t, err)
expect(t, doc, r, http.MethodGet, "/hello", nil, nil)
})
}
}

func TestRouter(t *testing.T) {
helloCONNECT := &openapi3.Operation{Responses: openapi3.NewResponses()}
helloDELETE := &openapi3.Operation{Responses: openapi3.NewResponses()}
Expand Down