openapi3: process discriminator mapping values as refs#1108
Merged
fenollp merged 1 commit intogetkin:masterfrom Mar 13, 2026
Merged
openapi3: process discriminator mapping values as refs#1108fenollp merged 1 commit intogetkin:masterfrom
fenollp merged 1 commit intogetkin:masterfrom
Conversation
While the type of the discriminator mapping values is a string in the upstream specs, it contains a jsonschema reference to a schema object. It is surprising behaviour that these refs are not handled when calling functions such as InternalizeRefs. This patch adds the data structures to store the ref internally, and updates the Loader and InternalizeRefs to handle this case.
5ae0b3a to
88588b5
Compare
Contributor
Author
|
@fenollp can you take a look at this? Is this project still maintained? |
fenollp
approved these changes
Mar 13, 2026
This was referenced Mar 26, 2026
reuvenharrison
pushed a commit
to oasdiff/kin-openapi
that referenced
this pull request
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the type of the discriminator mapping values is a string in the upstream specs, it contains a jsonschema reference to a schema object. It is surprising behaviour that these refs are not handled when calling functions such as InternalizeRefs.
This patch adds the data structures to store the ref internally, and updates the Loader and InternalizeRefs to handle this case.
This patch:
StringMapgeneric to support storing more than plain stringsMappingReftype to store discriminator mapping refs internallyLoaderto resolve discriminator mapping refsInternalizeRefsto handle discriminator mapping refsFixes #1021
This PR is another try of #1022