Skip to content

feat: implement disableHover, improve safeArea computation and other assertView fixes#1205

Merged
shadowusr merged 6 commits intotestplane@9from
users/shadowusr/TESTPLANE-886
Apr 9, 2026
Merged

feat: implement disableHover, improve safeArea computation and other assertView fixes#1205
shadowusr merged 6 commits intotestplane@9from
users/shadowusr/TESTPLANE-886

Conversation

@shadowusr
Copy link
Copy Markdown
Member

What's done:

  • Implemented a new assertView command option, called disableHover that behaves similarly to disableAnimation and is intended to be used with long screenshot where hovering over elements may introduce unwanted artifacts
  • Greatly improved safeArea computation algorithm, now it covers most (if not all) cases
  • Fixed page screenshots
  • Fixed error cause disappearance when passing it between master and worker
  • Implemented e2e fixture report and more e2e tests

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc62fd05b3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/camera/utils.ts Outdated
Comment thread src/browser/client-scripts/index.js
Comment thread src/browser/screen-shooter/index.ts
Comment thread src/config/defaults.js
Comment thread src/browser/camera/index.ts
@shadowusr shadowusr merged commit 2f54e2f into testplane@9 Apr 9, 2026
0 of 7 checks passed
@shadowusr shadowusr deleted the users/shadowusr/TESTPLANE-886 branch April 9, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants