Merge pull request actions#2160 from actions/ejahnGithub-patch-1

ejahnGithub · web-flow · commit acb230b99a46 · 2025-10-16T12:22:23.000-04:00
Remove unnecessary Buffer to Uint8Array conversion
diff --git a/packages/attest/src/attest.ts b/packages/attest/src/attest.ts
@@ -102,8 +102,7 @@ function toAttestation(bundle: Bundle, attestationID?: string): Attestation {
       throw new Error('Bundle must contain an x509 certificate')
   }
 
-  // Convert Buffer to Uint8Array for Node.js 24 compatibility
-  const signingCert = new X509Certificate(new Uint8Array(certBytes))
+  const signingCert = new X509Certificate(certBytes)
 
   // Collect transparency log ID if available
   const tlogEntries = bundle.verificationMaterial.tlogEntries

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,7 @@ function toAttestation(bundle: Bundle, attestationID?: string): Attestation {`
`102`	`102`	`throw new Error('Bundle must contain an x509 certificate')`
`103`	`103`	`}`
`104`	`104`
`105`		`- // Convert Buffer to Uint8Array for Node.js 24 compatibility`
`106`		`- const signingCert = new X509Certificate(new Uint8Array(certBytes))`
	`105`	`+ const signingCert = new X509Certificate(certBytes)`
`107`	`106`
`108`	`107`	`// Collect transparency log ID if available`
`109`	`108`	`const tlogEntries = bundle.verificationMaterial.tlogEntries`