Fix ie loading bug#395
Closed
dannyjlaurence-exp wants to merge 2 commits intofullstackreact:masterfrom
Closed
Conversation
* Fix script bug * Use yarn instead of npm
auser
reviewed
Feb 5, 2020
|
|
||
| dev: | ||
| npm run dev | ||
| yarn dev |
Contributor
There was a problem hiding this comment.
Let's keep this with npm as it's more universal still at this stage.
auser
reviewed
Feb 5, 2020
| "lint": "eslint ./src", | ||
| "lintfix": "eslint ./src --fix", | ||
| "testonly": "NODE_ENV=test mocha $npm_package_options_mocha", | ||
| "testonly": "NODE_ENV=test mocha --require scripts/mocha_runner -t rewireify src/**/__tests__/**/*.js", |
Contributor
There was a problem hiding this comment.
Why are we using rewireify here?
Author
|
Thanks! I missed this email. I'll follow your feedback soon. |
Contributor
|
Merged and published |
|
Hi, it looks like this https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-f7444d992b0a47df772a034af14b92648da3121d4a9af3fd58fd2b074546916dR76 never got published? Or am I missing something? I'm still getting the loaderCBXXXX error on IE and Edge on version 2.0.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #365
This PR has two things:
The specific fix for the loaderCB bug was pretty straightforward: The
handleResultcallback in the ScriptCache.js was being used bothonLoadand as the callback to the Google script being loaded. On Chrome, the google callback runs first reliably and in IE/Edge onLoad runs first reliably - so in IE the window.loaderCB function that the Google Script was trying to call was already cleaned up.To fix, I just naively sent a different named state to the
handleResultfunction, and also returned on resolve and reject. I'm a little unclear on if this will cause any other issues - but for what we use this project for - it works fine.