Skip to content

Commit e56d987

Browse files
ejona86ejona86
committed
core: Increase server handshake timeout to 120s
Previously it was 20s. 20s isn't _bad_, but may be too aggressive. Having it longer doesn't hurt us too much; we just need some bound. Since the MAX_BACKOFF on client-side is 120s, this will have client and server match, except for jitter. Although I will note that the client-side value covers more work than the server-side, such as attempting to connect to multiple hosts.
1 parent 76da37b commit e56d987

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public List<ServerServiceDefinition> getServices() {
7373
DecompressorRegistry.getDefaultInstance();
7474
private static final CompressorRegistry DEFAULT_COMPRESSOR_REGISTRY =
7575
CompressorRegistry.getDefaultInstance();
76-
private static final long DEFAULT_HANDSHAKE_TIMEOUT_MILLIS = TimeUnit.SECONDS.toMillis(20);
76+
private static final long DEFAULT_HANDSHAKE_TIMEOUT_MILLIS = TimeUnit.SECONDS.toMillis(120);
7777

7878
final InternalHandlerRegistry.Builder registryBuilder =
7979
new InternalHandlerRegistry.Builder();

0 commit comments

Comments
 (0)