Add support for .netStandard 2.0#17
Merged
Merged
Conversation
Owner
|
Thank you very much for the pull request! I apologize for the late reply. I will initially merge this to a local branch and start working on bringing this library fully up to .NET Standard/Core compatibility. I'm aiming for this to be a 4.0 release since as you say it will require alot of refactoring as well as replacing GDI+ functions and will update this thread with the progress. |
Owner
|
Thanks once again for the pull request! The develop branch is now updated to be compatible with .NET 4.x, Core 2.x and Standard 2.x. Once the new version is tested and considered stable it will be merged into master as version 4.0. |
Author
|
You're welcome! Glad I could help. Also glad that I can start using the
regular branch soon :)
brian
…On Sun, May 26, 2019 at 12:42 AM Fredrik Schultz ***@***.***> wrote:
Thanks once again for the pull request! The develop branch is now updated
to be compatible with .NET 4.x, Core 2.x and Standard 2.x. Once the new
version is tested and considered stable it will be merged into master as
version 4.0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17?email_source=notifications&email_token=AABE736AJWKVQBFZ3JQEHP3PXI5M7A5CNFSM4FQAV37KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIAHQY#issuecomment-495977411>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABE73Y4OYJ3BSHBNRQLMBLPXI5M7ANCNFSM4FQAV37A>
.
--
Brian
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm working on a Xamarin Forms project which requires the use of .netStandard 2.0 in one library. I made changes to support it, mainly removing the http streaming functions, as things like HttpContext and HttpResponse don't exist in .netStandard in the same way they do in .net 2.0. I tried to find workarounds, but wasn't successful so far. Would take major refactoring of the save* methods to accomplish it.