Use ssl.match_hostname from urllib3 as it was removed from Python 3.12 - #6912
Closed
rcritten wants to merge 1 commit into
Closed
Use ssl.match_hostname from urllib3 as it was removed from Python 3.12#6912rcritten wants to merge 1 commit into
rcritten wants to merge 1 commit into
Conversation
Contributor
Author
|
So urllib3.util.ssl_match_hostname was introduced in version 1.26.8. RHEL 9.x has 1.26.5 and I can't tell what version Azure has. I'll add a conditional import. Full release notes https://github.com/urllib3/urllib3/blob/main/CHANGES.rst |
rcritten
force-pushed
the
issue_9409
branch
2 times, most recently
from
July 7, 2023 01:03
49d863d to
a8a733a
Compare
Contributor
|
python3-urllib3 dependency needs to be added to Code changes LGTM. |
rcritten
force-pushed
the
issue_9409
branch
3 times, most recently
from
July 7, 2023 15:23
a2b7695 to
55f11f1
Compare
hroncok
reviewed
Jul 7, 2023
| %else | ||
| Requires: python3-setuptools | ||
| %endif | ||
| # Indirect dependency: use newer urllib3 with TLS 1.3 PHA support |
Contributor
There was a problem hiding this comment.
This is now a direct dependency, isn't it?
Contributor
Author
There was a problem hiding this comment.
This is just a copy of the existing placeholder for now while I fight with Azure to install the right dependencies in tox.
Based on upstream freeipa rawhide patch by Miro Hrončok See python/cpython#94224 (comment) Fixes: https://pagure.io/freeipa/issue/9409 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Contributor
|
LGTM. |
Contributor
|
master:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://pagure.io/freeipa/issue/9409
and python/cpython#94224 (comment)