Skip to content

Try to make a leak-detector for Configuration ClassLoaders#10636

Draft
tnleeuw wants to merge 8 commits intomasterfrom
feature/ClassLoadingLeakDetect
Draft

Try to make a leak-detector for Configuration ClassLoaders#10636
tnleeuw wants to merge 8 commits intomasterfrom
feature/ClassLoadingLeakDetect

Conversation

@tnleeuw
Copy link
Copy Markdown
Contributor

@tnleeuw tnleeuw commented Apr 3, 2026

Changes

Pull Request Checklist

Title

  • Title expresses the business value (who benefits + what outcome)

Issues

  • Relevant issue(s) linked
  • Confirmed with the issue creator(s) that the solution is satisfactory

Backports

  • Backport PRs created (if needed) and linked

Documentation

  • FF! Doc updated (user-facing behavior/config)
  • FF! Manual updated (if applicable)
  • Javadoc updated/generated (developer-facing APIs)

Tests

  • Unit tests added/updated
  • E2E/Integration tests added/updated (if applicable)

Breaking changes

  • Breaking change recorded in markdown file
  • Migration notes included (if needed)

@tnleeuw tnleeuw requested a review from nielsm5 April 3, 2026 10:41
@tnleeuw tnleeuw self-assigned this Apr 3, 2026
nielsm5
nielsm5 reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nielsm5 nielsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible we should create a little testset that's only enabled in iaf-test so we can test what happens after a few configuration reloads (with custom code). (I fear it will be a manual thing to test.)

I wish to remove the 'classloader map' in the manager alltogether so it becomes a factory for configurationClassLoaders and nothing more.

@tnleeuw
Copy link
Copy Markdown
Contributor Author

tnleeuw commented Apr 8, 2026

If possible we should create a little testset that's only enabled in iaf-test so we can test what happens after a few configuration reloads (with custom code). (I fear it will be a manual thing to test.)

I wish to remove the 'classloader map' in the manager alltogether so it becomes a factory for configurationClassLoaders and nothing more.

I will look at making such a test-set in this PR, and if that map can already be removed in this same PR as well or better not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielsm5 nielsm5 nielsm5 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@tnleeuw tnleeuw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tnleeuw @nielsm5