Add BERT QA support#451
Draft
andrea-fasoli wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Andrea Fasoli <andrea.fasoli@ibm.com>
Signed-off-by: Andrea Fasoli <andrea.fasoli@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for BERT Question Answering (one task only).
The architecture is named
bert_question_answering. This selection will build an FMSRoBERTaQuestionAnsweringmodel using BERT config. The models appear to be almost identical, except for max position embeddings and vocab type size, which have been adjusted in the config.PR includes:
hf_pretrainedDraft PR for now, because accuracy of both FP16 and FP8 models is not on par with expectations (F1 ~ 55% instead of >70%).
Unit tests are passing.