apps/web/modules/organization/settings/api-keys/actions.ts (1)

23-32: 🧹 Nitpick | 🔵 Trivial

Extract repeated org-role access config to a shared constant.

The same access block is duplicated three times. Centralizing it reduces auth drift risk.

♻️ Proposed refactor

 const ZDeleteApiKeyAction = z.object({
   id: ZId,
 });
 
+const OWNER_MANAGER_ORG_ACCESS = [
+  {
+    type: "organization" as const,
+    roles: ["owner", "manager"] as const,
+  },
+];
+
 export const deleteApiKeyAction = authenticatedActionClient.inputSchema(ZDeleteApiKeyAction).action(
   withAuditLogging("deleted", "apiKey", async ({ ctx, parsedInput }) => {
     const organizationId = await getOrganizationIdFromApiKeyId(parsedInput.id);
     await checkAuthorizationUpdated({
       userId: ctx.user.id,
       organizationId,
-      access: [
-        {
-          type: "organization",
-          roles: ["owner", "manager"],
-        },
-      ],
+      access: OWNER_MANAGER_ORG_ACCESS,
     });
@@
     await checkAuthorizationUpdated({
       userId: ctx.user.id,
       organizationId: parsedInput.organizationId,
-      access: [
-        {
-          type: "organization",
-          roles: ["owner", "manager"],
-        },
-      ],
+      access: OWNER_MANAGER_ORG_ACCESS,
     });
@@
     await checkAuthorizationUpdated({
       userId: ctx.user.id,
       organizationId,
-      access: [
-        {
-          type: "organization",
-          roles: ["owner", "manager"],
-        },
-      ],
+      access: OWNER_MANAGER_ORG_ACCESS,
     });

As per coding guidelines "Keep code DRY (Don't Repeat Yourself) and small; remove dead code and unused imports".

Also applies to: 50-59, 78-87

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/web/modules/organization/settings/api-keys/actions.ts` around lines 23 -
32, Extract the repeated access block into a shared constant (e.g.,
ORG_OWNER_MANAGER_ACCESS) and replace the three inline usages passed to
checkAuthorizationUpdated(...) with that constant; locate the occurrences where
checkAuthorizationUpdated is called (the calls that pass access: [{ type:
"organization", roles: ["owner","manager"] }]) and import/define the constant
adjacent to the module-level scope so all calls use the same reference to avoid
duplication and future drift.