Skip to content

remove request package and replace with native http#598

Closed
shannamurry wants to merge 1 commit into
form-data:masterfrom
shannamurry:remove_request_package
Closed

remove request package and replace with native http#598
shannamurry wants to merge 1 commit into
form-data:masterfrom
shannamurry:remove_request_package

Conversation

@shannamurry
Copy link
Copy Markdown

@shannamurry shannamurry commented Jan 14, 2026

The request package is deprecated and is causing this repo to come up as a critical vulnerability via dependabot and guardrails

@ljharb
Copy link
Copy Markdown
Member

ljharb commented Jan 14, 2026

If you have a tool that complains about a dependency's dev dependencies, do not trust that tool, since it's broken.

I'm happy to add an example using native http, but the example with request is valid and will remain. Also, using a deprecated package isn't a security issue, and things shouldn't be complaining about it.

@shannamurry
Copy link
Copy Markdown
Author

Nevertheless, request is deprecated

@ljharb
Copy link
Copy Markdown
Member

ljharb commented Jan 14, 2026

Sure, and? It's a dev dependency, so consumers of this package should literally never care about it.

@shannamurry
Copy link
Copy Markdown
Author

Please review this - for those of us that are using this package in enterprise applications it is triggering security alerts that we are getting audited on. There is no patched version of request that resolves this vulnerability. If you don't remove the package we will have to find an alternative to form-data which is going to cost us time and effort. https://security.snyk.io/package/npm/request/2.87.0
Screenshot 2026-01-15 at 11 42 17 AM

@ljharb
Copy link
Copy Markdown
Member

ljharb commented Jan 15, 2026

I understand that request has an unpatched vulnerability. It is not used in the production dependency graph of this package, however, so merging this PR will have no effect on the security of your application. Can you show me why snyk thinks request is coming into your application via form-data?

@shannamurry
Copy link
Copy Markdown
Author

I actually had the dependency tree wrong on this - apologies. closing the pr.

@ljharb ljharb added the invalid label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants