[camera_platform_interface] Add setJpegImageQuality method#11454
[camera_platform_interface] Add setJpegImageQuality method#11454auto-submit[bot] merged 5 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the setJpegImageQuality method to the camera_platform_interface package, enabling control over JPEG compression quality. The update includes the interface definition, method channel implementation, and unit tests. Feedback suggests adding an assertion to validate the quality range and wrapping the method channel call in a try-catch block to throw a CameraException for consistent error handling.
|
@bparrishMines @hellohuanlin @LouiseHsu Could you review this? It's the platform interface subset of #11155, split out per the federated plugin process. |
|
@Bolling88 I will take a look! 😸 But for future reference may I gently suggest requesting viewers through the side panel? It adds the PR to the review list, while manually tagging reviewers only generates an email that can easily get lost. :) |
Thank you! But I think I lack the necessary permissions to add reviewers. At least that option does not exist for me when I try :( Anyhow, we also need @bparrishMines approval before proceeding? |
yes, we should def wait for him! But i think this requires at least 2 reviewers to merge. |
|
All approvals are in — could someone land this? :) |
…er#185287) flutter/packages@c2e3d1f...01c505f 2026-04-20 engine-flutter-autoroll@skia.org Roll Flutter from 8e8a194 to 2844af6 (13 revisions) (flutter/packages#11531) 2026-04-17 stuartmorgan@google.com [google_maps_fluter] Switch to Kotlin Pigeon (flutter/packages#11522) 2026-04-17 engine-flutter-autoroll@skia.org Roll Flutter (stable) from db50e20 to cc0734a (8 revisions) (flutter/packages#11525) 2026-04-17 engine-flutter-autoroll@skia.org Roll Flutter from 31f1802 to 8e8a194 (22 revisions) (flutter/packages#11523) 2026-04-17 stuartmorgan@google.com [google_maps_flutter] Fix various Java warnings (flutter/packages#11516) 2026-04-16 srawlins@google.com [google_maps_flutter] Use super parameters in more places in examples (flutter/packages#11517) 2026-04-16 engine-flutter-autoroll@skia.org Roll Flutter from c1b14e9 to 31f1802 (46 revisions) (flutter/packages#11518) 2026-04-15 stuartmorgan@google.com [tool] Update java formatter (flutter/packages#11508) 2026-04-15 stuartmorgan@google.com [quick_actions] Remove manual thread hop in Android response (flutter/packages#11445) 2026-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.6.0 to 1.7.0 in the all-github-actions group (flutter/packages#11510) 2026-04-14 magder@google.com Skip dependabot updates for minor versions of gradle and kotlin (flutter/packages#11509) 2026-04-14 chick.developer@gmail.com [go_router] Fix pop() restoring stale configuration when route has onExit (flutter/packages#11241) 2026-04-14 stuartmorgan@google.com [url_launcher] Switch to Kotlin Pigeon (flutter/packages#11473) 2026-04-14 okorohelijah@google.com [pr-fix] Run all flutter/packages macOS tests using Xcode 26 and iOS 26 simulator (flutter/packages#10635) 2026-04-14 bolling.ludwig@gmail.com [camera_platform_interface] Add setJpegImageQuality method (flutter/packages#11454) 2026-04-14 engine-flutter-autoroll@skia.org Roll Flutter from 2fa45e0 to c1b14e9 (19 revisions) (flutter/packages#11506) 2026-04-14 stuartmorgan@google.com [local_auth] Switch to Kotlin Pigeon (flutter/packages#11482) 2026-04-13 fluttergithub-bot@google.com Sync release-go_router to main (flutter/packages#11499) 2026-04-13 slater.jay@gmail.com [mustache_template] Fix auto-generated specification tests, run with `dart test` (flutter/packages#11056) 2026-04-13 engine-flutter-autoroll@skia.org Roll Flutter from bf18e39 to 2fa45e0 (19 revisions) (flutter/packages#11497) 2026-04-10 engine-flutter-autoroll@skia.org Roll Flutter from 81c87ea to bf18e39 (18 revisions) (flutter/packages#11488) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Platform interface changes for adding JPEG compression quality control to the camera plugin. This is the platform interface subset of #11155, split out per the federated plugin contribution process.
Fixes flutter/flutter#183229
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2