Skip to content

[flutter_releases] Flutter Stable 2.2.2 Framework Cherrypicks#84364

Merged
christopherfujino merged 7 commits intoflutter:flutter-2.2-candidate.10from
chris-forks:cherrypicks-flutter-2.2-candidate.10
Jun 11, 2021
Merged

[flutter_releases] Flutter Stable 2.2.2 Framework Cherrypicks#84364
christopherfujino merged 7 commits intoflutter:flutter-2.2-candidate.10from
chris-forks:cherrypicks-flutter-2.2-candidate.10

Conversation

@christopherfujino
Copy link
Copy Markdown
Contributor

@christopherfujino christopherfujino commented Jun 10, 2021 •
edited
Loading

Scheduled Cherrypicks

Known Presubmit Failures

@flutter-dashboard
Copy link
Copy Markdown

flutter-dashboard bot commented Jun 10, 2021

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 10, 2021
@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 10, 2021
@skia-gold
Copy link
Copy Markdown

skia-gold commented Jun 10, 2021

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/84364

@christopherfujino
Copy link
Copy Markdown
Contributor Author

christopherfujino commented Jun 10, 2021

Analysis failures:

  error • A value of type 'dynamic' can't be assigned to a variable of type 'FakeProcessManager' • packages/flutter_tools/test/general.shard/dart/pub_get_test.dart:30:47 • invalid_assignment
  error • The method 'empty' isn't defined for the type 'FakeProcessManager' • packages/flutter_tools/test/general.shard/dart/pub_get_test.dart:30:66 • undefined_method
  error • 1 positional argument(s) expected, but 0 found • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1589:31 • not_enough_positional_arguments
  error • The named parameter 'fileSystem' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1590:11 • undefined_named_parameter
  error • The named parameter 'inputPathString' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1591:11 • undefined_named_parameter
  error • The named parameter 'outputPathString' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1592:11 • undefined_named_parameter
  error • The named parameter 'templateArbFileName' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1593:11 • undefined_named_parameter
  error • The named parameter 'outputFileString' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1594:11 • undefined_named_parameter
  error • The named parameter 'classNameString' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1595:11 • undefined_named_parameter
  error • 1 positional argument(s) expected, but 0 found • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1704:31 • not_enough_positional_arguments
  error • The named parameter 'fileSystem' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1705:11 • undefined_named_parameter
  error • The named parameter 'inputPathString' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1706:11 • undefined_named_parameter
  error • The named parameter 'outputPathString' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1707:11 • undefined_named_parameter
  error • The named parameter 'templateArbFileName' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1708:11 • undefined_named_parameter
  error • The named parameter 'outputFileString' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1709:11 • undefined_named_parameter
  error • The named parameter 'classNameString' isn't defined • packages/flutter_tools/test/general.shard/generate_localizations_test.dart:1710:11 • undefined_named_parameter

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 10, 2021
@skia-gold
Copy link
Copy Markdown

skia-gold commented Jun 10, 2021

Gold has detected about 2 new digest(s) on patchset 4.
View them at https://flutter-gold.skia.org/cl/github/84364

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@skia-gold
Copy link
Copy Markdown

skia-gold commented Jun 10, 2021

Gold has detected about 1 new digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/84364

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@skia-gold
Copy link
Copy Markdown

skia-gold commented Jun 10, 2021

Gold has detected about 6 new digest(s) on patchset 6.
View them at https://flutter-gold.skia.org/cl/github/84364

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@skia-gold
Copy link
Copy Markdown

skia-gold commented Jun 10, 2021

Gold has detected about 2 new digest(s) on patchset 7.
View them at https://flutter-gold.skia.org/cl/github/84364

@christopherfujino christopherfujino marked this pull request as ready for review June 10, 2021 22:32
@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Jun 10, 2021
jonahwilliams
jonahwilliams approved these changes Jun 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Copy Markdown
Contributor Author

christopherfujino commented Jun 11, 2021

Overriding CLAbot as all commit authors have signed the CLA, the bot just doesn't know how to handle multiple authors.

@christopherfujino christopherfujino merged commit d79295a into flutter:flutter-2.2-candidate.10 Jun 11, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-2.2-candidate.10 branch June 11, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christopherfujino @skia-gold @jonahwilliams @xu-baolin @goderbauer