[flutter_tools] Remove outdated columnWidth comment from wrapText function #82650
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom May 17, 2021
TahaTesser:fix_wrap_text_columnwidth_doc
Merged
[flutter_tools] Remove outdated columnWidth comment from wrapText function #82650fluttergithubbot merged 1 commit intoflutter:masterfrom TahaTesser:fix_wrap_text_columnwidth_doc
columnWidth comment from wrapText function #82650fluttergithubbot merged 1 commit intoflutter:masterfrom
TahaTesser:fix_wrap_text_columnwidth_doc
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
columnWidth from wrapText function columnWidth from wrapText function
columnWidth from wrapText function columnWidth comment from wrapText function
Contributor
|
@TahaTesser you'll need to ask for a test exemption from @Hixie |
Contributor
|
test-exempt: only removes code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
columnWidthinsidewrapTextfunction is no longer optional, I feel that this comment should be removed and it would close an issue as wellCloses #68783
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.