Skip to content

Remove the bringup flag from the linux_arm_host_desktop_engine builder - #190935

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jason-simmons:bug_190893_bringup
Aug 11, 2026
Merged

Remove the bringup flag from the linux_arm_host_desktop_engine builder#190935
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jason-simmons:bug_190893_bringup

Conversation

@jason-simmons

Copy link
Copy Markdown
Member

This builder was recently created in a refactoring of the Linux arm64 builders (see #180235)

The builder was not being scheduled in the merge queue because it is marked as "bringup: true" (see #190893)

This builder was recently created in a refactoring of the Linux arm64 builders (see flutter#180235)

The builder was not being scheduled in the merge queue because it is marked as "bringup: true" (see flutter#190893)
@jason-simmons
jason-simmons requested a review from jtmcdole August 11, 2026 16:53
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 11, 2026
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Aug 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'bringup: true' property from the 'Linux linux_arm_host_desktop_engine' target in the CI configuration file '.ci.yaml'. There are no review comments, and I have no feedback to provide.

@jtmcdole jtmcdole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💵 The CodeFu LGTM Note

The LGTM exchange rates are currently trading at:

  • 1 LGTM = golden images match closely enough if I squint.
  • 2 LGTMs = I checked that this won't break the devicelab benchmarks
  • 3 LGTMs = I trust that this C++ pointer won't leak memory every frame.
  • 4 LGTMs = CI is green on the first try without a single retry or shard failure

💵 Value officially backed by the full faith, credit, and compute budget of the Flutter EngProd Infrastructure.

image_1786120554622963

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2026
@auto-submit

auto-submit Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/190935, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Aug 11, 2026
Merged via the queue into flutter:master with commit 8837b1f Aug 11, 2026
33 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants