fix(bottom_sheet): fix dismissal near minimum extent when shouldCloseOnMinExtent- #190705 - #190810
Open
kirya355 wants to merge 1 commit into
Open
fix(bottom_sheet): fix dismissal near minimum extent when shouldCloseOnMinExtent- #190705#190810kirya355 wants to merge 1 commit into
kirya355 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the bottom sheet closing logic in bottom_sheet.dart and scaffold.dart to use precisionErrorTolerance when comparing the current extent to the minimum extent, and adds corresponding tests. The review feedback suggests that using absolute difference (.abs() < precisionErrorTolerance) may fail to close the bottom sheet if the extent drops below the minimum, and recommends using notification.extent - notification.minExtent <= precisionErrorTolerance to safely handle both nearly-equal and less-than cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw material is freezed but after this answer I reopened PR
flutter/packages#12392 (comment)
Fixes bottom sheet dismissal when a
DraggableScrollableNotificationextentis within floating-point precision of
minExtent, rather than exactly equal.Updates both
BottomSheetandScaffoldnotification handlers and addsregression tests for modal and standard bottom sheets using
extent: 0.20000000001withminExtent: 0.2.Tests
bin/flutter test packages/flutter/test/material/bottom_sheet_test.dartPre-launch Checklist
///).