Add text rendering test to engine_integration_golden_test - #190678
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a new integration test for text rendering, including a test application TextRenderingApp that displays text with various font weights and colors, and updates the Roboto font configuration. The feedback recommends adding documentation comments to the public class TextRenderingApp and its constructor to comply with the Flutter Style Guide.
There was a problem hiding this comment.
Code Review
This pull request updates the local test execution instructions in the README, introduces a new text rendering integration test with its corresponding application, and registers the Roboto variable font in the pubspec.yaml. Feedback recommends explicitly defining the font weights (100, 400, and 700) for the variable font asset in pubspec.yaml to ensure correct mapping and rendering by the Flutter engine.
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm, I wonder if that gamma PR gets reverted if it's too subtle for our skiagold algorithm.
I've seen skia gold report much subtler changes. So I think changes like this will get a new screenshot that requires triage in skia gold. |
|
PTAL. Turns out I can't bundle the font with the app because the flutter repo doesn't want us checking in non-text files: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8674190463682008689/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout. I changed this to use the google_fonts package instead. |
Add text rendering test to engine_integration_golden_test
Part of #190301
Manual run on Windows:
Compare with a manual run that includes a revert of #190477:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.