[flutter_tools] Replace usages of package:dds/dap.dart with package:dap_adapters/dap_adapters.dart - #190667
Open
bkonyi wants to merge 5 commits into
Open
[flutter_tools] Replace usages of package:dds/dap.dart with package:dap_adapters/dap_adapters.dart#190667bkonyi wants to merge 5 commits into
bkonyi wants to merge 5 commits into
Conversation
…ap_adapters/dap_adapters.dart Migrate Debug Adapter Protocol (DAP) adapter imports in flutter_tools from package:dds/dap.dart to package:dap_adapters/dap_adapters.dart. Also update package:flutter_tools pubspec.yaml dependencies and pubspec checksum.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several package dependencies across the repository, including upgrades to meta, vector_math, and video_player. It also introduces the dap_adapters package and migrates debug adapter imports from package:dds/dap.dart to package:dap_adapters/dap_adapters.dart. Feedback was provided to maintain alphabetical ordering of dependencies in packages/flutter_tools/pubspec.yaml by placing dap_adapters before dds.
Comment on lines
+16
to
+17
| dds: 5.3.0 | ||
| dap_adapters: 1.0.0 |
Contributor
There was a problem hiding this comment.
To maintain alphabetical order of dependencies in pubspec.yaml, dap_adapters should be placed before dds.
dap_adapters: 1.0.0
dds: 5.3.0…ency and update checksum
…ain alphabetical order
…sage # Conflicts: # dev/integration_tests/hook_user_defines/pubspec.yaml # packages/flutter_tools/pubspec.yaml # pubspec.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Debug Adapter Protocol (DAP) adapter imports in flutter_tools from package:dds/dap.dart to package:dap_adapters/dap_adapters.dart.