Adds missing await on instantiateImageCodecFromBuffer#188910
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request modifies the instantiateImageCodecFromBuffer function in painting.dart to be asynchronous by adding the async modifier and awaiting the call to engine.renderer.instantiateImageCodec. There are no review comments, and I have no feedback to provide.
|
test-exempt: unblocks future Dart roll |
This is merely a work towards:
We are now making the new
analyzerwarning trigger on non-asynccases too because that is probably what the code is meant to do.I don't expect this change to break any tests. If it does, we caught an untracked error.
Pre-launch Checklist
///).