Fix AppBar title route announcements on iOS and macOS#187621
Draft
hannah-hyj wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the AppBar title semantics by unconditionally setting the namesRoute flag to true on all platforms when header semantics are not excluded, rather than conditionally setting it based on the target platform. Correspondingly, the unit tests have been updated to verify that the namesRoute flag is non-null across all platforms using TargetPlatformVariant.all(). There are no review comments, and I have no feedback to provide.
Member
Author
|
converting this to draft because of the code freeze |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #185894
see discussion in #185894
Previously, from PR #16081 (from April 2018)
namesRouteonAppBar.title'sSemanticswidget was set tonullon iOS and macOS to follow iOS conventions.This PR sets
namesRoutetotrueon theAppBar's title semantics across all platforms, matching standard WCAG 2.4.2 page-titled guidelines.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.