Add iOS prebuilt impeller_sdk#187608
Conversation
There was a problem hiding this comment.
Code Review
This pull request enables building and archiving the standalone Impeller SDK for iOS and iOS Simulator platforms by updating build configurations, dependencies, and documentation. The reviewer identified that the include_paths in mac_ios_engine.json should be relative to the base_path to prevent double-nested path resolution failures, and provided suggestions to correct them.
| "base_path": "out/ci/ios_debug_sim/zip_archives/", | ||
| "type": "gcs", | ||
| "include_paths": [ | ||
| "out/ci/ios_debug_sim/zip_archives/ios-sim-x64/impeller_sdk.zip" |
There was a problem hiding this comment.
The paths in include_paths must be relative to the base_path. Including the full path prefix here will cause the archiver to look for the file at a double-nested path, which will fail to find the artifact.
| "out/ci/ios_debug_sim/zip_archives/ios-sim-x64/impeller_sdk.zip" | |
| "ios-sim-x64/impeller_sdk.zip" |
| "base_path": "out/ci/ios_debug_sim_arm64/zip_archives/", | ||
| "type": "gcs", | ||
| "include_paths": [ | ||
| "out/ci/ios_debug_sim_arm64/zip_archives/ios-sim-arm64/impeller_sdk.zip" |
There was a problem hiding this comment.
The paths in include_paths must be relative to the base_path. Including the full path prefix here will cause the archiver to look for the file at a double-nested path, which will fail to find the artifact.
| "out/ci/ios_debug_sim_arm64/zip_archives/ios-sim-arm64/impeller_sdk.zip" | |
| "ios-sim-arm64/impeller_sdk.zip" |
| "base_path": "out/ci/ios_debug/zip_archives/", | ||
| "type": "gcs", | ||
| "include_paths": [ | ||
| "out/ci/ios_debug/zip_archives/ios-arm64/impeller_sdk.zip" |
There was a problem hiding this comment.
The paths in include_paths must be relative to the base_path. Including the full path prefix here will cause the archiver to look for the file at a double-nested path, which will fail to find the artifact.
| "out/ci/ios_debug/zip_archives/ios-arm64/impeller_sdk.zip" | |
| "ios-arm64/impeller_sdk.zip" |
923d522 to
be22754
Compare
Fixes #169553