feat: Allow recognizer inside editable#187599
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the assertion assert(readOnly && !obscureText); from RenderEditable when generating semantics nodes for text fragments with recognizers. The review feedback highlights that completely removing this assertion introduces a security risk by allowing obscured text (such as passwords) to be exposed to accessibility services. It is recommended to retain the assertion assert(!obscureText); to maintain safety for obscured text fields.
19992ec to
30a02a3
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Should I create a unit test for this kind of change ? |
Flutter should not (if possible) block devs to use recognizer inside an editable text. Apps like Whatsapp display inline autocomplete and so user can click on the suggested word to use it.
For instance :
Linked issues :
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.