Revert "Add support for stylus buttons"#187581
Conversation
This reverts commit f2877c6.
There was a problem hiding this comment.
Code Review
This pull request removes support for inverted stylus device kinds and stylus-specific button flags from the embedder API and the Windows platform implementation. The Windows platform pointer event handling has been refactored to remove the generic buttons parameter, replacing it with a button parameter for down and up events that is converted to mouse buttons. Associated unit tests and fixtures have been updated or removed to reflect these changes. I have no feedback to provide as there are no review comments.
|
Quick question: how is the process to reland prs again? |
|
@CodeDoctorDE Yup that's right, please create a new PR with the fix. If you want to go the extra mile, I'd recommend that you squash your commits such that the original PR is the first commit, and the fix is the second commit. That makes it easier to review, but it's not required :) |
|
Do i need to wait until this pr is merged? |
Reverts: Add support for stylus buttons
Initiated by: @loic-sharma
Reason for reverting: This PR causes the
Windows windows_host_engine_testto fail. cc @CodeDoctorDEOriginal PR Author: @CodeDoctorDE
Reviewed By: @mattkae
The original PR description is provided below:
Continuation of #165323.
Now we have stylus support on windows with the last pull request.
This pull request now adds support for
invertedStylusand stylus buttons (primary + secondary).The pull request shouldn't have any breaking changes other than the pointer event shows the correct button bitmap instead of
1always on a stylus input.Should completly fix: #102836.
Tested on my notebook:
repo for the demo code: https://github.com/CodeDoctorDE/flutter-input-demo
This pull request is currently a draft and my next steps is to add tests
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.