Add dedicated rubber band spring for overscroll recovery in BouncingScrollPhysics#187568
Open
MTtankkeo wants to merge 2 commits into
Open
Add dedicated rubber band spring for overscroll recovery in BouncingScrollPhysics#187568MTtankkeo wants to merge 2 commits into
MTtankkeo wants to merge 2 commits into
Conversation
…ncingScrollPhysics
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new rubberBandSpring to BouncingScrollPhysics to simulate iOS-style exponential decay for stationary overscroll releases, updating related tests to reflect faster animation convergence. Feedback on the changes highlights a potential logic regression in createBallisticSimulation where using <= instead of < to define isStationary alters behavior when the velocity is exactly equal to the tolerance threshold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Relanding #182426.
Thank you for your review and guidance on the previous PR.
I'm relanding this with the fix for the test failures that caused the issue before. (I've updated the regression test to account for the faster convergence rate of the new physics.)
Fixes #181752
(for detailed analysis, measurements, and discussion, please refer to the original issue.)
This pull request implements a dedicated “rubber band” physics for overscroll snap-back in BouncingScrollPhysics on iOS to better match the native UIScrollView feel.
Note
This change adjusts spring constants and simulation behavior
to improve iOS scroll fidelity.
Given that this change primarily involves physics parameter tuning,
it may reasonably qualify as test-exempt. However, I am not entirely
certain what level of automated testing would be considered appropriate.
Please let me know if additional tests are expected,
and I am happy to update the PR accordingly.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.