Reverts "[web, tool] Support recompiling shaders and unify asset processing (#185534)"#186837
Merged
auto-submit[bot] merged 1 commit intoMay 20, 2026
Merged
Conversation
fluttergithubbot
approved these changes
May 20, 2026
Contributor
Author
|
auto label is removed for flutter/flutter/186837, Failed to enqueue flutter/flutter/186837 with HTTP 400: Pull request Required status check "Merge Queue Guard" is expected.. |
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
1 similar comment
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
Contributor
Author
|
auto label is removed for flutter/flutter/186837, Failed to enqueue flutter/flutter/186837 with HTTP 400: Pull request Required status check "Merge Queue Guard" is queued.. |
This was referenced May 21, 2026
matthewhendrix
pushed a commit
to matthewhendrix/flutter
that referenced
this pull request
May 23, 2026
…essing (flutter#185534)" (flutter#186837) <!-- start_original_pr_link --> Reverts: flutter#185534 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: chunhtai <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: cause test flakes <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: kevmoo <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {harryterkelsen} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: User-visible fixes: - Hot RESTART: should reload for all assets. - Hot RELOAD: should reload all assets EXCEPT shaders. Will need to do that in a follow-up. Addresses SOME of flutter#137265 (Images, JSON, Text, Data Files) Extracted core asset sync logic (incremental checks, transformers, and shader recompilation) into a shared static method `DevFS.updateBundle`. This aligns the web asset path with other platforms and correctly enables support for asset transformers during web hot reload/restart. Previously, `WebDevFS` used a custom asset loop that bypassed the transformer step and silently ignored shader compilation failures. Changes: - Refactored `DevFS.update` to use the new `DevFS.updateBundle` helper. - Updated `WebDevFS` to leverage `DevFS.updateBundle` and `LocalDevFSWriter`. - Fixed a path resolution bug in `WebDevFS` where assets were resolving to incorrect nested paths. - Added comprehensive tests in `devfs_web_test.dart` for shader recompilation, asset transformers, and failure handling. - Ensured that shader compilation failures correctly report an update failure in the FS report. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: #185534
Initiated by: chunhtai
Reason for reverting: cause test flakes
Original PR Author: kevmoo
Reviewed By: {harryterkelsen}
This change reverts the following previous change:
User-visible fixes:
Addresses SOME of #137265 (Images, JSON, Text, Data Files)
Extracted core asset sync logic (incremental checks, transformers, and
shader recompilation) into a shared static method
DevFS.updateBundle.This aligns the web asset path with other platforms and correctly
enables support for asset transformers during web hot reload/restart.
Previously,
WebDevFSused a custom asset loop that bypassed thetransformer step and silently ignored shader compilation failures.
Changes:
DevFS.updateto use the newDevFS.updateBundlehelper.WebDevFSto leverageDevFS.updateBundleandLocalDevFSWriter.WebDevFSwhere assets were resolvingto incorrect nested paths.
devfs_web_test.dartfor shaderrecompilation, asset transformers, and failure handling.
failure in the FS report.