Clarify ActivityAware v1 embedding support#186565
Open
mvincentong wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Android migration documentation and plugin Javadocs to clarify that ActivityAware callbacks are exclusive to the v2 embedding, requiring plugin authors to maintain registerWith for backward compatibility with pre-1.12 projects. The review feedback suggests improving technical precision by explicitly mentioning 'callbacks' instead of the interface name and optimizing Javadoc tags for better navigation and tool compatibility.
9c3425b to
e8ebcae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59556
Description
ActivityAwareis part of the v2 Android embedding, but the existing Javadocs did not say what happens for pre-1.12 projects still using the v1 embedding. This clarifies that v1 embedding projects invoke a plugin staticregisterWithpath instead and do not callActivityAwarecallbacks.The change updates the
ActivityAwareJavadoc, the relatedFlutterPluginoverview, and the local pre-1.12 Android migration note.Tests
git diff --checkNot run: engine Java formatting, because this checkout does not have the hermetic Java/google-java-format artifacts under
engine/src/flutter/third_partywithoutgclient sync.Risk
Docs-only change. No generated output.