Preserve SelectableRegion scope across context menu rebuilds#186553
Open
mvincentong wants to merge 1 commit into
Open
Preserve SelectableRegion scope across context menu rebuilds#186553mvincentong wants to merge 1 commit into
mvincentong wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a GlobalKey to SelectableRegionState to maintain the SelectableRegionSelectionStatusScope subtree across rebuilds. It also adds a widget test to ensure SelectableRegion can rebuild on the web after disabling the browser context menu. Feedback indicates that the new private GlobalKey should include public-quality documentation and a debugLabel to align with the Flutter style guide.
01851b9 to
4007a07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186459
Description
SelectableRegionconditionally wraps its selection subtree inPlatformSelectableRegionContextMenuon desktop web. WhenBrowserContextMenu.enabledchanges, that wrapper can be removed while the existing rootSelectionContaineris still registered, causing a replacement container to register before the old one unregisters.This keeps the selection status scope keyed from
SelectableRegionState, so the selection subtree is reparented across the optional wrapper change instead of recreated.Tests
../../bin/flutter test --platform chrome test/widgets/selectable_region_test.dart --plain-name 'BrowserContextMenu'./bin/flutter analyze packages/flutter/lib/src/widgets/selectable_region.dart packages/flutter/test/widgets/selectable_region_test.dart./bin/dart format --output=none --set-exit-if-changed packages/flutter/lib/src/widgets/selectable_region.dartgit diff --check