Update dart_skills_lint dependency to e449787 and optimize skills validation test#186528
Update dart_skills_lint dependency to e449787 and optimize skills validation test#186528reidbaker wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a configuration file for dart_skills_lint and updates validate_skills_test.dart to utilize it, alongside a dependency update. Feedback suggests resolving the configuration path relative to the repository root to avoid fragility, removing redundant directory parameters already defined in the configuration, and implementing a more maintainable method for disabling lint rules.
| }, | ||
| ); | ||
| final Configuration config = await ConfigParser.loadConfig(path: _configFilePath); | ||
| final bool isValid = await validateSkills(skillDirPaths: [skillsDirectory], config: config); |
There was a problem hiding this comment.
The skillDirPaths argument appears redundant here because the config object (loaded from dart_skills_lint.yaml) already specifies the target directory (.agents/skills). Providing both might lead to the same directory being scanned twice, which contradicts the goal of optimizing validation overhead. Consider removing the explicit skillDirPaths if the configuration is intended to be the source of truth for the validation.
There was a problem hiding this comment.
ConfigParser doesn't have .agent/skills in it...
Updates the pinned Git reference for
dart_skills_lintindev/tools/pubspec.yamlto commit hashe4497873950727ee781fa411c1a2f624b1ec50c6(version0.3.0).Introduces a standalone
dev/tools/dart_skills_lint.yamlconfiguration file and refactorsdev/tools/test/validate_skills_test.dartto dynamically load and enforce this centralized configuration.All default built-in rules are explicitly disabled within the secondary backticks validation test block for performance.
References flutter/skills#85
Pre-launch Checklist
///).