Update iOS scenario app test goldens to match changes from https://github.com/flutter/flutter/pull/182662#186390
Open
jason-simmons wants to merge 1 commit into
Open
Update iOS scenario app test goldens to match changes from https://github.com/flutter/flutter/pull/182662#186390jason-simmons wants to merge 1 commit into
jason-simmons wants to merge 1 commit into
Conversation
…2662 That PR affected golden image tests that use platform views. But the images had not been updated in the PR because errors in the "Mac mac_unopt" suite were suppressed on the dashboard when the PR landed.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
b-luk
approved these changes
May 12, 2026
Contributor
b-luk
left a comment
There was a problem hiding this comment.
Thanks, Jason!
If even these changes are above the RMSE threshold, I wonder what it takes to be under the threshold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That PR affected golden image tests that use platform views. But the images had not been updated in the PR because errors in the "Mac mac_unopt" suite were suppressed on the dashboard when the PR landed.