Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter#186378
Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter#186378vashworth wants to merge 1 commit into
Conversation
…ateXcodebuildArgs
There was a problem hiding this comment.
Code Review
This pull request refactors the XcodeProjectInterpreter class and its callers to pass XcodeBasedProject objects instead of raw string paths to methods such as getInfo, getBuildSettings, cleanWorkspace, and prefetchSwiftPackages. This change requires updates across various commands, migrations, and a significant number of test files to accommodate the new method signatures. Feedback indicates a potential inconsistency in prefetchSwiftPackages where the project path should point to the .xcodeproj directory for the xcodebuild command, and a suggestion to align the working directory in cleanWorkspace with the project's host app root.
hellohuanlin
left a comment
There was a problem hiding this comment.
thanks for breaking into smaller PRs
Pass
XcodeBasedProjectinstead of the project path string.This will enable us to be able to get more information about the project (other than just the project path) from places in
xcodeproj.dart. Needed for #185218, https://github.com/flutter/flutter/pull/186006/changes#r3191012567Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.