Clarify BackdropFilter does not affect native platform views#186367
Clarify BackdropFilter does not affect native platform views#186367mboetger wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds documentation to clarify that the BackdropFilter widget only filters content rendered by Flutter and does not affect native platform views. The review feedback recommends enhancing this documentation by linking to specific platform view widgets and using standard terminology to align with the repository's style guide.
| /// This widget only filters content rendered by Flutter. It does not affect | ||
| /// native platform views (like Android views or iOS views) because those views | ||
| /// are rendered by the platform itself, not by Flutter's engine. |
There was a problem hiding this comment.
To adhere to the Flutter style guide, consider linking to the definitions of the terms introduced. Using specific widget references like [AndroidView] and [UiKitView] provides better context for 'platform views'. Additionally, 'the Flutter engine' is the standard terminology used in the documentation.
/// This widget only filters content rendered by Flutter. It does not affect
/// platform views (such as [AndroidView] or [UiKitView]) because those views
/// are rendered by the platform itself, not by the Flutter engine.References
- Introduce terms: Assume the reader does not know everything. Link to definitions. (link)
gmackall
left a comment
There was a problem hiding this comment.
FYI I think this isn't true on iOS (it has some effects, but not perfect visual fidelity?), and also I think (but don't know) it isn't true on TLHC
…native platform views
52b3abd to
2699d7b
Compare
Update dart documentation to clarify filtering rules only affect Flutter views.
Fixes: #132089
Pre-launch Checklist
///).