Paint scaffold persistent bottom sheet background color behind the keyboard#186365
Draft
victorsanni wants to merge 6 commits into
Draft
Paint scaffold persistent bottom sheet background color behind the keyboard#186365victorsanni wants to merge 6 commits into
victorsanni wants to merge 6 commits into
Conversation
Contributor
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix applies to persistent bottom sheets:
Scaffold.bottomSheet,showBottomSheet, andScaffoldState.showBottomSheet.For modal bottom sheets (e.g
showModalBottomSheet,showCupertinoModalPopup), the modal is pushed as a new route onto theNavigator, and so the developer remains in control of the entire modal region (including the area behind the keyboard).However in persistent sheets
Scaffold.resizeToAvoidBottomInsetstripsviewInsets.bottom, so the sheet is bounded by the keyboard with no control over the area behind the keyboard. So this fix adds a new Scaffold slot:_ScaffoldSlot.bottomSheetKeyboardBackdropwhich adds a backdrop behind the keyboard matching the background color of the sheet.Before:
After:
