Support custom BoxBorder animation in BoxDecoration#186348
Open
gabrimatic wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables BoxDecoration to handle interpolation and scaling for custom BoxBorder subclasses by introducing a private _lerpBorder method that utilizes ShapeBorder.lerp. New tests verify this functionality using a custom border implementation. Feedback suggests simplifying nullable type checks and renaming a local variable to avoid shadowing and improve idiomatic Dart usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180297
BoxDecoration now preserves the existing specialized Border and BorderDirectional interpolation path, while custom BoxBorder subclasses use ShapeBorder.lerp. This lets custom borders provide their own interpolation hooks and avoids the AnimatedContainer assertion when animating a BoxDecoration with a custom border.
Tests: