Fix nested Text.rich semantics order#186116
Merged
auto-submit[bot] merged 4 commits intoMay 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the semantics configuration logic in RenderParagraph to process text information sequentially and introduces the _childConfigBelongsToPlaceholder helper method for tag validation. It also adds a test case for nested rich text semantics. Feedback suggests adding documentation to the new private method to align with the repository style guide.
Contributor
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM, w some small comments.
Renzo-Olivares
previously approved these changes
May 13, 2026
Contributor
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM, this will need a secondary reviewer before landing. Thank you for the contribution!
Renzo-Olivares
approved these changes
May 13, 2026
Contributor
|
autosubmit label was removed for flutter/flutter/186116, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
This was referenced May 15, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 15, 2026
flutter/flutter@0541913...1ceffd1 2026-05-14 ikramhasan.dev@gmail.com Fix selection highlight artifacts for faded selectable text (flutter/flutter#183628) 2026-05-14 46920873+gabrimatic@users.noreply.github.com Fix nested Text.rich semantics order (flutter/flutter#186116) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176570
Nested
Text.richwidgets can inherit placeholder semantics tags from ancestor paragraphs. When those inherited tags reuse the same placeholder index as the nested paragraph,RenderParagraphcan merge all placeholder child semantics before the inline text segment.This emits combined text semantics in span order and matches placeholder children against the direct placeholder tag so nested widget spans keep their accessibility label order.
Tests:
../../bin/flutter test test/widgets/text_test.dart --plain-name='semantics label is in order with nested rich text widget spans'../../bin/flutter test test/widgets/text_test.dart../../bin/flutter analyze --no-pub lib/src/rendering/paragraph.dart test/widgets/text_test.dart