feat(web): implement image decoding throttling for HTML images#186032
Merged
auto-submit[bot] merged 7 commits intoMay 7, 2026
Merged
Conversation
Introduces a centralized ImageDecodingManager to coordinate the concurrency and memory footprint of HTMLImageElement.decode() calls. This prevents resource exhaustion and silent crashes on browsers like iOS Safari when handling high volumes of large image assets. - Added ImageDecodingManager to enforce safety limits (20 decodes / 128MB). - Refactored HtmlImageElementCodec to use a multi-phase throttled decode. - Implemented aggressive resource reclamation by clearing img.src on disposal. - Added unit tests for the manager and updated codec integration tests.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an ImageDecodingManager to throttle HTMLImageElement.decode() calls, addressing resource exhaustion and crashes on browsers like iOS Safari. The HtmlImageElementCodec is refactored into a multi-phase asynchronous process that manages concurrency and memory limits through a centralized FIFO queue. Feedback focuses on improving resource reclamation by clearing image sources during failures and enhancing error reporting by wrapping decoding operations in descriptive exceptions.
mdebbar
previously approved these changes
May 5, 2026
mdebbar
approved these changes
May 7, 2026
This was referenced May 8, 2026
This was referenced May 8, 2026
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a centralized ImageDecodingManager to coordinate the concurrency and memory footprint of
HTMLImageElement.decode()calls. This prevents resource exhaustion and silent crashes on browsers like iOS Safari when handling high volumes of large image assets.Largely alleviates #152709
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.