Fix App binary path for SwiftPM Add2App on macOS#185769
Merged
auto-submit[bot] merged 4 commits intoMay 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Swift package build process to use direct versioned paths for the App framework binary on macOS, replacing symlinks in the FlutterAssembleInputs.xcfilelist template. Corresponding tests were added to verify the pathing for both iOS and macOS. Feedback suggests extending this logic to other symlinked paths in the templates, including the Flutter framework binary and code signature resources, and ensuring consistency in the output file list.
Contributor
|
autosubmit label was removed for flutter/flutter/185769, because - The status or check suite Windows tool_integration_tests_3_10 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This was referenced May 2, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently Xcode Run Script don't work with the binary symlink in macOS framework. So this PR updates it to use the direct path
Fixes #185837.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.