Fix naming of hello_world_impeller_macos_sdfs#185681
Conversation
There was a problem hiding this comment.
Code Review
This pull request renames the hello_world_macos_impeller_macos_sdfs task to hello_world_impeller_macos_sdfs in .ci.yaml and TESTOWNERS. Feedback indicates that the entry in TESTOWNERS is now out of alphabetical order and that the physical file rename is missing from the PR, which will cause CI failures.
| /dev/devicelab/bin/tasks/hello_world_impeller_ios_sdfs.dart @gaaclarke @flutter/engine | ||
| /dev/devicelab/bin/tasks/hello_world_macos__compile.dart @cbracken @flutter/desktop | ||
| /dev/devicelab/bin/tasks/hello_world_macos_impeller_macos_sdfs.dart @b-luk @flutter/desktop | ||
| /dev/devicelab/bin/tasks/hello_world_impeller_macos_sdfs.dart @b-luk @flutter/desktop |
There was a problem hiding this comment.
The entry for hello_world_impeller_macos_sdfs.dart is out of alphabetical order. It should be moved before hello_world_macos__compile.dart (line 280) to maintain the file's organization and readability.
Additionally, the physical file rename from hello_world_macos_impeller_macos_sdfs.dart to hello_world_impeller_macos_sdfs.dart is not included in this pull request. If the file is not renamed, the CI tasks will fail to find the script.
References
- Optimize for readability: Code is read more often than it is written. (link)
There was a problem hiding this comment.
Alphabetized this line.
Additionally, the physical file rename from
hello_world_macos_impeller_macos_sdfs.darttohello_world_impeller_macos_sdfs.dartis not included in this pull request.
The file is already named hello_world_impeller_macos_sdfs.dart, so no renaming is needed.
Fix naming in a couple places where an extra "macos" was added in #185565
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.