Fixes Impeller Frame capture scope for macOS.#185656
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request introduces Metal capture scoping for Impeller by setting a default capture scope and adding start/finish capture calls during frame rendering in debug mode. Review feedback suggests clearing the global capture scope in the destructor to avoid stale references and optimizing the frame submission path by avoiding unnecessary shared pointer increments in release builds.
| [[MTLCaptureManager sharedCaptureManager] | ||
| setDefaultCaptureScope:current_capture_scope_]; |
There was a problem hiding this comment.
Setting the defaultCaptureScope on the shared MTLCaptureManager is a global operation that affects the entire process. To avoid potential issues with stale references or unexpected behavior if multiple Metal contexts are used, consider clearing this default scope in the destructor of ImpellerMetalCaptureManager (or its owner) when it is no longer needed.
Before this capturing a GPU frame in Xcode would just hang because StartCapture and StopCapture were not being called.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.