Skip to content

Replace Material import with animation in semantics_and_children_test#185626

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
MohamedGawdat:remove-material-from-semantics-and-children-test
Apr 29, 2026
Merged

Replace Material import with animation in semantics_and_children_test#185626
auto-submit[bot] merged 3 commits into
flutter:masterfrom
MohamedGawdat:remove-material-from-semantics-and-children-test

Conversation

@MohamedGawdat
Copy link
Copy Markdown
Contributor

@MohamedGawdat MohamedGawdat commented Apr 27, 2026

Part of #177412

Summary

packages/flutter/test/rendering/semantics_and_children_test.dart imported package:flutter/material.dart only to transitively pull in AnimationController. Replaces that with the narrower package:flutter/animation.dart import — no symbols from the material library were actually used.

The two existing tests (RenderOpacity and children and semantics) continue to pass unchanged.

Pre-launch Checklist

Tests

  • ./bin/dart analyze packages/flutter/test/rendering/semantics_and_children_test.dart
  • ./bin/flutter test packages/flutter/test/rendering/semantics_and_children_test.dart

@MohamedGawdat
Replace Material import with animation in semantics_and_children_test
24600c7 
The test in `packages/flutter/test/rendering/semantics_and_children_test.dart`
imported `package:flutter/material.dart` only to transitively pull in
`AnimationController`. Replace it with the narrower
`package:flutter/animation.dart` import.

No behavior change.
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Apr 27, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the imports in packages/flutter/test/rendering/semantics_and_children_test.dart, replacing the material.dart import with animation.dart. I have no feedback to provide as there are no review comments.

@MohamedGawdat
Copy link
Copy Markdown
Contributor Author

MohamedGawdat commented Apr 27, 2026

Test exemption note: this is a no-semantic-change refactor — the material.dart import is replaced by the narrower animation.dart import (which is what was actually being used, transitively, for AnimationController). No behavior change. The existing tests in this file pass unchanged. Per Tree Hygiene, refactors of this kind are not auto-exempt; happy to request an explicit test-exempt: <reason> from @test-exemption-reviewer on Discord if a reviewer prefers.

@victorsanni victorsanni added the CICD Run CI/CD label Apr 27, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 27, 2026
@MohamedGawdat
Copy link
Copy Markdown
Contributor Author

MohamedGawdat commented Apr 28, 2026 •
edited
Loading

Sorry @victorsanni — I pushed a master-merge commit right after your approval, which auto-removed the CICD label. The PR contents are unchanged from what you reviewed (only a merge with master, no code changes). Could you re-add CICD ? My apologies for the noise.

@MohamedGawdat
Copy link
Copy Markdown
Contributor Author

MohamedGawdat commented Apr 28, 2026

@rkishan516 asking if could you add CI/CD lable please

@rkishan516 rkishan516 added the CICD Run CI/CD label Apr 28, 2026
@MohamedGawdat
Copy link
Copy Markdown
Contributor Author

MohamedGawdat commented Apr 28, 2026

LGTM

@MohamedGawdat
Copy link
Copy Markdown
Contributor Author

MohamedGawdat commented Apr 28, 2026 •
edited
Loading

Hi @okorohelijah @gaaclarke @victorsanni @reidbaker
PR is approved & checks passed — could you help merge and add autosubmit label if possible? Thanks!
Edit: it seems i need second approval first 😅

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2026
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit Bot commented Apr 28, 2026

autosubmit label was removed for flutter/flutter/185626, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2026
@MohamedGawdat
Copy link
Copy Markdown
Contributor Author

MohamedGawdat commented Apr 28, 2026

@gaaclarke
It seems that i need 2 pr approvals first, not one 😅

@AbdeMohlbi AbdeMohlbi added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 29, 2026
Merged via the queue into flutter:master with commit 7c411ca Apr 29, 2026
94 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2026
This was referenced Apr 29, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 30, 2026
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victorsanni victorsanni victorsanni approved these changes

@AbdeMohlbi AbdeMohlbi AbdeMohlbi approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) CICD Run CI/CD framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MohamedGawdat @victorsanni @AbdeMohlbi @gaaclarke @rkishan516